jenkins-bot has submitted this change and it was merged.
Change subject: Use PHPUnit_Framework_TestCase in a few utils/ tests
......................................................................
Use PHPUnit_Framework_TestCase in a few utils/ tests
IPTest, StringUtilsTest and ZipDirectoryReaderTest do not
need the extra overhead
Change-Id: Ic05afb1a3a094a57383d483f4e50bd1ed9a183e2
---
M tests/phpunit/includes/utils/IPTest.php
M tests/phpunit/includes/utils/StringUtilsTest.php
M tests/phpunit/includes/utils/ZipDirectoryReaderTest.php
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/utils/IPTest.php
b/tests/phpunit/includes/utils/IPTest.php
index ebe347f..09c1587 100644
--- a/tests/phpunit/includes/utils/IPTest.php
+++ b/tests/phpunit/includes/utils/IPTest.php
@@ -9,7 +9,7 @@
* dataprovider.
*/
-class IPTest extends MediaWikiTestCase {
+class IPTest extends PHPUnit_Framework_TestCase {
/**
* not sure it should be tested with boolean false. hashar 20100924
* @covers IP::isIPAddress
diff --git a/tests/phpunit/includes/utils/StringUtilsTest.php
b/tests/phpunit/includes/utils/StringUtilsTest.php
index 0fdb8e1..7c24fae 100644
--- a/tests/phpunit/includes/utils/StringUtilsTest.php
+++ b/tests/phpunit/includes/utils/StringUtilsTest.php
@@ -1,6 +1,6 @@
<?php
-class StringUtilsTest extends MediaWikiTestCase {
+class StringUtilsTest extends PHPUnit_Framework_TestCase {
/**
* This tests StringUtils::isUtf8 whenever we have the mbstring
extension
diff --git a/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php
b/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php
index 34ffb53..05d07d4 100644
--- a/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php
+++ b/tests/phpunit/includes/utils/ZipDirectoryReaderTest.php
@@ -4,7 +4,7 @@
* @covers ZipDirectoryReader
* NOTE: this test is more like an integration test than a unit test
*/
-class ZipDirectoryReaderTest extends MediaWikiTestCase {
+class ZipDirectoryReaderTest extends PHPUnit_Framework_TestCase {
protected $zipDir;
protected $entries;
--
To view, visit https://gerrit.wikimedia.org/r/182144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic05afb1a3a094a57383d483f4e50bd1ed9a183e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
