Unicodesnowman has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182408
Change subject: Rename testBug32548Exponent to testExponentLineBreaking
......................................................................
Rename testBug32548Exponent to testExponentLineBreaking
Fix for @todo
Change-Id: I0dcef36fe9cee95ae320b535bac883d5e26ad140
---
M tests/phpunit/includes/libs/JavaScriptMinifierTest.php
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/08/182408/1
diff --git a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php
b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php
index 26b81cc..5576502 100644
--- a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php
+++ b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php
@@ -164,7 +164,7 @@
);
}
- public static function provideBug32548() {
+ public static function provideExponentLineBreaking() {
return array(
array(
// This one gets interpreted all together by
the prior code;
@@ -183,14 +183,13 @@
}
/**
- * @dataProvider provideBug32548
+ * @dataProvider provideExponentBreaking
* @covers JavaScriptMinifier::minify
- * @todo give this test a real name explaining what is being tested here
*/
- public function testBug32548Exponent( $num ) {
+ public function testExponentLineBreaking( $num ) {
// Long line breaking was being incorrectly done between the
base and
// exponent part of a number, causing a syntax error. The line
should
- // instead break at the start of the number.
+ // instead break at the start of the number. (T34548)
$prefix = 'var longVarName' . str_repeat( '_', 973 ) . '=';
$suffix = ',shortVarName=0;';
--
To view, visit https://gerrit.wikimedia.org/r/182408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dcef36fe9cee95ae320b535bac883d5e26ad140
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Unicodesnowman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
