[MediaWiki-commits] [Gerrit] don't 'return' when security field is 'default' unless is_ne... - change (phabricator...security)

[Rush (Code Review)]

Rush has submitted this change and it was merged.

Change subject: don't 'return' when security field is 'default' unless is_new 
is true
......................................................................


don't 'return' when security field is 'default' unless is_new is true

Change-Id: I065b890c6408c7814ec55b1b5ce54aa13f20d5bb
---
M src/policy/SecurityPolicyListener.php
M src/policy/WMFSecurityPolicy.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Rush: Verified; Looks good to me, approved



diff --git a/src/policy/SecurityPolicyListener.php 
b/src/policy/SecurityPolicyListener.php
index 7dcffc2..e6f4392 100644
--- a/src/policy/SecurityPolicyListener.php
+++ b/src/policy/SecurityPolicyListener.php
@@ -27,7 +27,7 @@
     $type_hasproj = PhabricatorProjectObjectHasProjectEdgeType::EDGECONST;
     $security_setting = WMFSecurityPolicy::getSecurityFieldValue($task);
 
-    if ($security_setting == 'none' || $security_setting == 'default') {
+    if ($is_new && $security_setting == 'default') {
       return;
     }
 
diff --git a/src/policy/WMFSecurityPolicy.php b/src/policy/WMFSecurityPolicy.php
index 19540c8..9ab8447 100644
--- a/src/policy/WMFSecurityPolicy.php
+++ b/src/policy/WMFSecurityPolicy.php
@@ -78,7 +78,7 @@
           break;
       }
     }
-    return $transactions;
+    return array_values($transactions);
   }
 
   /**

-- 
To view, visit https://gerrit.wikimedia.org/r/182977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I065b890c6408c7814ec55b1b5ce54aa13f20d5bb
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/security
Gerrit-Branch: master
Gerrit-Owner: 20after4 <mmod...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits