jenkins-bot has submitted this change and it was merged.
Change subject: Add "?source=app" to the end of all share a fact URLs per
Analytics.
......................................................................
Add "?source=app" to the end of all share a fact URLs per Analytics.
Our EventLogging infrastructure captures the generation and sharing of facts,
but Analytics would like the ability to track how much the links are clicked,
and the best way to do that is to add a URL parameter tracking the source.
This patch adds such a parameter, conforming to the spec given to me by the
Analytics team.
Change-Id: Ie43d02653c00f40c4e1a95bcd7b05ac32f33da56
---
M wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
b/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
index 66ad722..a196bcb 100644
---
a/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
@@ -135,7 +135,7 @@
PageTitle title = curPageFragment.getTitle();
String introText = activity.getString(R.string.snippet_share_intro,
title.getDisplayText(),
- title.getCanonicalUri());
+ title.getCanonicalUri() + "?source=app");
Bitmap resultBitmap = SnippetImage.createImage(activity,
curPageFragment.getLeadImageBitmap(),
curPageFragment.getImageBaseYOffset(),
--
To view, visit https://gerrit.wikimedia.org/r/183306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie43d02653c00f40c4e1a95bcd7b05ac32f33da56
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
