EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/183750
Change subject: Bug: Update the number of expected items when increasing page
size
......................................................................
Bug: Update the number of expected items when increasing page size
When repeating queries to get enough items when doing application
level filtering the pager was trying to increase the page size after
the third query to ensure we get enough items. Unfortunatly we didn't
update the number of items we expected back, so it stopped repeating.
This patch updates so the pager checks the options to see how many
items it should have recieved, rather than maintaining an independant
variable.
Change-Id: I0cd2b51f46dd2f2175688a3a2171c7b196503887
---
M includes/Data/Pager/Pager.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/50/183750/1
diff --git a/includes/Data/Pager/Pager.php b/includes/Data/Pager/Pager.php
index b2536c7..1b4cf88 100644
--- a/includes/Data/Pager/Pager.php
+++ b/includes/Data/Pager/Pager.php
@@ -132,7 +132,7 @@
$results = array_merge( $results, $filtered );
}
- if ( count( $found ) !== $numRequested ) {
+ if ( count( $found ) !== $options['limit'] ) {
// last page
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/183750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cd2b51f46dd2f2175688a3a2171c7b196503887
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
