Prtksxna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/183765
Change subject: Add a check for the EventLogging library before the logEvent
call
......................................................................
Add a check for the EventLogging library before the logEvent call
Bug: T70341
Change-Id: Idae926b1ddce544ab37b95018abc13879f515f71
---
M resources/ext.popups.eventlogging.js
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/65/183765/1
diff --git a/resources/ext.popups.eventlogging.js
b/resources/ext.popups.eventlogging.js
index 3e7b183..bf4da2f 100644
--- a/resources/ext.popups.eventlogging.js
+++ b/resources/ext.popups.eventlogging.js
@@ -56,8 +56,13 @@
*
* @method logEvent
* @param {String} href
+ * @return {Boolean} logged Whether or not the event was logged
*/
eventLogging.logEvent = function ( href ) {
+ if ( mw.eventLog === undefined ) {
+ return false;
+ }
+
var
deferred = $.Deferred(),
event = {
@@ -81,6 +86,8 @@
eventLogging.time = undefined;
eventLogging.duration = undefined;
eventLogging.action = undefined;
+
+ return true;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/183765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idae926b1ddce544ab37b95018abc13879f515f71
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
