jenkins-bot has submitted this change and it was merged.
Change subject: Use Family.langs for categories_last in WOW family
......................................................................
Use Family.langs for categories_last in WOW family
Wikia extension CategorySelect places categories after interwiki links.
This applies to all langs, and using an explicit list of lang codes
obscures the configuration of this Family.
Bug: T86284
Change-Id: I69f4ef31e6216de54b5bce16e1d0508018271d3e
---
M pywikibot/families/wowwiki_family.py
M pywikibot/family.py
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/families/wowwiki_family.py
b/pywikibot/families/wowwiki_family.py
index 25289cc..8199386 100644
--- a/pywikibot/families/wowwiki_family.py
+++ b/pywikibot/families/wowwiki_family.py
@@ -55,11 +55,7 @@
self.disambcatname['en'] = "Disambiguations"
# Wikia's default CategorySelect extension always puts categories last
- self.categories_last = [
- 'cs', 'da', 'de', 'el', 'en', 'es', 'fa',
- 'fi', 'fr', 'he', 'hr', 'hu', 'is', 'it', 'ja', 'ko', 'lt', 'lv',
- 'nl', 'no', 'pl', 'pt', 'pt-br', 'ro', 'ru', 'sk', 'sr', 'sv',
- 'tr', 'zh-tw', 'zh']
+ self.categories_last = self.langs.keys()
def scriptpath(self, code):
"""Return the script path for this family."""
diff --git a/pywikibot/family.py b/pywikibot/family.py
index bf04dbb..b48055b 100644
--- a/pywikibot/family.py
+++ b/pywikibot/family.py
@@ -713,6 +713,8 @@
# String used as separator between category links and the text
self.category_text_separator = config.line_separator * 2
# When both at the bottom should categories come after interwikilinks?
+ # TODO: T86284 Needed on Wikia sites, as it uses the CategorySelect
+ # extension which puts categories last on all sites. TO BE DEPRECATED!
self.categories_last = []
# Which languages have a special order for putting interlanguage
--
To view, visit https://gerrit.wikimedia.org/r/183769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69f4ef31e6216de54b5bce16e1d0508018271d3e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
