jenkins-bot has submitted this change and it was merged.
Change subject: Fix fingerprint values in entityview when scraping from html
......................................................................
Fix fingerprint values in entityview when scraping from html
It is expected that the first language in self.options.languages
is the user language of the page, so preserve that before
scraping the other values from the html.
Bug: T75749
Change-Id: I9ef80d967db8f4c5d295b221fe72ed8a5ce05b0c
---
M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Henning Snater: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
index 69b8918..d889c39 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
@@ -243,7 +243,7 @@
} else {
// Scrape languages from static HTML:
// FIXME: Currently, this simply overrules the
languages options.
- self.options.languages = [];
+ self.options.languages = [ self.options.languages[0] ];
this.$fingerprints.find(
'.wikibase-entitytermsforlanguageview' ).each( function() {
$.each( $( this ).attr( 'class' ).split( ' ' ),
function() {
if( this.indexOf(
'wikibase-entitytermsforlanguageview-' ) === 0 ) {
--
To view, visit https://gerrit.wikimedia.org/r/183567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ef80d967db8f4c5d295b221fe72ed8a5ce05b0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
