jenkins-bot has submitted this change and it was merged.
Change subject: Fix the overlay chevron position for RTL
......................................................................
Fix the overlay chevron position for RTL
Bug: T78330
Change-Id: Ie438042bc24b8ace429eec68c8b75c09da56aa95
---
M modules/overlay/ext.echo.overlay.less
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/overlay/ext.echo.overlay.less
b/modules/overlay/ext.echo.overlay.less
index 8deb08d..4352313 100644
--- a/modules/overlay/ext.echo.overlay.less
+++ b/modules/overlay/ext.echo.overlay.less
@@ -30,8 +30,16 @@
position: absolute;
z-index: 101;
top: -@chevronHeight;
- // subtract half the width from the offset and then add the
left box shadow
- left: @offset - 10px + 3px;
+
+ /* @noflip */ body.ltr & {
+ // subtract half the width from the offset and then add
the left box shadow
+ /* @noflip */ left: @offset - 10px + 3px;
+ }
+
+ /* @noflip */ body.rtl & {
+ // subtract the box shadow
+ /* @noflip */ left: @offset - 3px;
+ }
}
button {
--
To view, visit https://gerrit.wikimedia.org/r/182658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie438042bc24b8ace429eec68c8b75c09da56aa95
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
