Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184151

Change subject: Allow numeric headers in Sidebar
......................................................................

Allow numeric headers in Sidebar

A numeric string set as key of an array gets casted to an integer. Since
I458c0af3114754ddf3d721f6c374e249f482e4cf wfMessage does not except
integer as message key, therefore cast the heading name back to string.

Bug: T73639
Change-Id: I376fb49d03251a71372738c531a09f014540b958
---
M VectorTemplate.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/51/184151/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 4acfa8c..56e3937 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -282,6 +282,9 @@
                                continue;
                        }
 
+                       // Numeric strings gets an integer when set as key, 
cast back - T73639
+                       $name = (string)$name;
+
                        switch ( $name ) {
                                case 'SEARCH':
                                        break;

-- 
To view, visit https://gerrit.wikimedia.org/r/184151
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I376fb49d03251a71372738c531a09f014540b958
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to