Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/184205
Change subject: Move DeferredStringifier into libs, add tests ...................................................................... Move DeferredStringifier into libs, add tests Change-Id: I384d1a3854e957315584d30ec58c48c02fee6a2c --- M autoload.php R includes/libs/DeferredStringifier.php A tests/phpunit/includes/libs/DeferredStringifierTest.php 3 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/05/184205/1 diff --git a/autoload.php b/autoload.php index 674d4b0..72345fe 100644 --- a/autoload.php +++ b/autoload.php @@ -292,7 +292,7 @@ 'DateFormatter' => __DIR__ . '/includes/parser/DateFormatter.php', 'DeadendPagesPage' => __DIR__ . '/includes/specials/SpecialDeadendpages.php', 'DeferrableUpdate' => __DIR__ . '/includes/deferred/DeferredUpdates.php', - 'DeferredStringifier' => __DIR__ . '/includes/DeferredStringifier.php', + 'DeferredStringifier' => __DIR__ . '/includes/libs/DeferredStringifier.php', 'DeferredUpdates' => __DIR__ . '/includes/deferred/DeferredUpdates.php', 'DeleteAction' => __DIR__ . '/includes/actions/DeleteAction.php', 'DeleteArchivedFiles' => __DIR__ . '/maintenance/deleteArchivedFiles.php', diff --git a/includes/DeferredStringifier.php b/includes/libs/DeferredStringifier.php similarity index 100% rename from includes/DeferredStringifier.php rename to includes/libs/DeferredStringifier.php diff --git a/tests/phpunit/includes/libs/DeferredStringifierTest.php b/tests/phpunit/includes/libs/DeferredStringifierTest.php new file mode 100644 index 0000000..45f5e37 --- /dev/null +++ b/tests/phpunit/includes/libs/DeferredStringifierTest.php @@ -0,0 +1,23 @@ +<?php + +class DeferredStringifierTest extends PHPUnit_Framework_TestCase { + + /** + * @covers DeferredStringifier + * @dataProvider provideToString + */ + public function testToString( $params, $expected ) { + $class = new ReflectionClass( 'DeferredStringifier' ); + $ds = $class->newInstanceArgs( $params ); + $this->assertEquals( $expected, (string)$ds ); + } + + public static function provideToString() { + return array( + // No args + array( array( function() { return 'foo'; } ), 'foo' ), + // Has args + array( array( function( $i ) { return $i; }, 'bar' ), 'bar' ), + ); + } +} \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/184205 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I384d1a3854e957315584d30ec58c48c02fee6a2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits