Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184279

Change subject: Emit position after opening/closing a window
......................................................................

Emit position after opening/closing a window

As the window manager hides the scroll bar, thus changing the
viewport width.

Bug: T85844
Change-Id: Idb1fbc842639391c4e4a2c7813df63e4f9ecb598
---
M src/ui/actions/ve.ui.WindowAction.js
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/79/184279/1

diff --git a/src/ui/actions/ve.ui.WindowAction.js 
b/src/ui/actions/ve.ui.WindowAction.js
index 09326bb..695e8d0 100644
--- a/src/ui/actions/ve.ui.WindowAction.js
+++ b/src/ui/actions/ve.ui.WindowAction.js
@@ -63,8 +63,12 @@
        }
 
        windowManager.openWindow( name, data ).then( function ( closing ) {
-               closing.then( function () {
+               surface.getView().emit( 'position' );
+               closing.then( function ( closed ) {
                        surface.getView().activate();
+                       closed.then( function () {
+                               surface.getView().emit( 'position' );
+                       } );
                } );
        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/184279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb1fbc842639391c4e4a2c7813df63e4f9ecb598
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to