KartikMistry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184594
Change subject: pep8: Fixed comments
......................................................................
pep8: Fixed comments
Change-Id: I9dcb1418d6547eed9055efa971c1f775e887d262
---
M modules/admin/data/data_admin.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/94/184594/1
diff --git a/modules/admin/data/data_admin.py b/modules/admin/data/data_admin.py
index 7e7fa9c..f856cf9 100644
--- a/modules/admin/data/data_admin.py
+++ b/modules/admin/data/data_admin.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python
-#2014 Chase Pettet
-#beginnings of a linter for data.yaml
+# 2014 Chase Pettet
+# beginnings of a linter for data.yaml
import sys
import yaml
@@ -25,7 +25,7 @@
def dict_sort(dictionary):
- #dumping ordered dict to yaml causes issues, return normal dict
+ # dumping ordered dict to yaml causes issues, return normal dict
return dict(collections.OrderedDict(sorted(dictionary.items())))
@@ -44,14 +44,14 @@
all_users = admins['users'].keys()
grouped_users = all_assigned_users(admins)
- #ensure all assigned users exist
+ # ensure all assigned users exist
non_existent_users = [u for u in grouped_users if u not in all_users]
if non_existent_users:
lint_error = True
print "Users assigned that do not exist: %s" % (
non_existent_users,)
- #ensure no two groups uses the same gid
+ # ensure no two groups uses the same gid
gids = filter(None, [
v.get('gid', None) for k, v in admins['groups'].iteritems()])
dupes = [k for k, v in Counter(gids).items() if v > 1]
--
To view, visit https://gerrit.wikimedia.org/r/184594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dcb1418d6547eed9055efa971c1f775e887d262
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: KartikMistry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
