Werdna has uploaded a new change for review. https://gerrit.wikimedia.org/r/184890
Change subject: Composer exec "creates" should be vendor, not composer.lock ...................................................................... Composer exec "creates" should be vendor, not composer.lock The composer documentation recommends committing composer.lock into your source repo: https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file Change-Id: I69d658d584ea83254a83086242085266f24c327c --- M puppet/modules/php/manifests/composer/install.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant refs/changes/90/184890/1 diff --git a/puppet/modules/php/manifests/composer/install.pp b/puppet/modules/php/manifests/composer/install.pp index 25aeb37..fdfb181 100644 --- a/puppet/modules/php/manifests/composer/install.pp +++ b/puppet/modules/php/manifests/composer/install.pp @@ -29,7 +29,7 @@ 'COMPOSER_NO_INTERACTION=1', ], user => 'vagrant', - creates => "${directory}/composer.lock", + creates => "${directory}/vendor", require => [ Class['::php::composer'], ], -- To view, visit https://gerrit.wikimedia.org/r/184890 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I69d658d584ea83254a83086242085266f24c327c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vagrant Gerrit-Branch: master Gerrit-Owner: Werdna <agarr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
