Reedy has submitted this change and it was merged.
Change subject: Fix array index for oldid parameter
......................................................................
Fix array index for oldid parameter
This caused an incorrect oldid parameter to be passed to parsoid on html2wt
conversion, resulting in dirty diffs.
Change-Id: If140bbc94f280f9ec5a1c9f6d9c3b4e7a46e1917
(cherry picked from commit 03aee0e0cdd5503c580bba240616b0515c9d011f)
---
M includes/libs/virtualrest/ParsoidVirtualRESTService.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Reedy: Verified; Looks good to me, approved
diff --git a/includes/libs/virtualrest/ParsoidVirtualRESTService.php
b/includes/libs/virtualrest/ParsoidVirtualRESTService.php
index 34e43f9..03bdf0d 100644
--- a/includes/libs/virtualrest/ParsoidVirtualRESTService.php
+++ b/includes/libs/virtualrest/ParsoidVirtualRESTService.php
@@ -88,8 +88,8 @@
if ( !isset( $req['body']['html'] ) ) {
throw new Exception( "You must
set an 'html' body key for this request" );
}
- if ( isset( $parts[6] ) ) {
- $req['body']['oldid'] =
$parts[6];
+ if ( isset( $parts[7] ) ) {
+ $req['body']['oldid'] =
$parts[7];
}
} elseif ( $parts[3] == 'wikitext' && $parts[5]
== 'html' ) {
if ( !isset( $req['body']['wikitext'] )
) {
--
To view, visit https://gerrit.wikimedia.org/r/185072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If140bbc94f280f9ec5a1c9f6d9c3b4e7a46e1917
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf14
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
