Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/185405
Change subject: Catch exceptions thrown by navigator.sendBeacon ...................................................................... Catch exceptions thrown by navigator.sendBeacon Exceptions can happen when AdBlock Plus blocks event.gif Bug: T86680 Change-Id: I4eba6b94fbd0816c6f84bea80c09ea7dbf2064fd --- M modules/ext.eventLogging.core.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging refs/changes/05/185405/1 diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js index 16fe3da..10b3b17 100644 --- a/modules/ext.eventLogging.core.js +++ b/modules/ext.eventLogging.core.js @@ -224,7 +224,7 @@ sendBeacon: !baseUrl ? $.noop : navigator.sendBeacon - ? function ( url ) { navigator.sendBeacon( url ); } + ? function ( url ) { try { navigator.sendBeacon( url ); } catch ( e ) {} } : function ( url ) { document.createElement( 'img' ).src = url; }, /** -- To view, visit https://gerrit.wikimedia.org/r/185405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4eba6b94fbd0816c6f84bea80c09ea7dbf2064fd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits