jenkins-bot has submitted this change and it was merged.
Change subject: siteselector: Degrade on pressing ESC
......................................................................
siteselector: Degrade on pressing ESC
Bug: T40360
Change-Id: I73c01caaba521af8cc2a1a1c904196f676766110
---
M lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
b/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
index e5033c1..b0c4364 100644
--- a/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
+++ b/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
@@ -52,6 +52,26 @@
.one( 'selected', function( event, item
) {
self.element.val(
item.getValue() );
} );
+ } else if( event.keyCode ===
$.ui.keyCode.ESCAPE ) {
+ var degrade = true,
+ firstItem =
self.options.menu.option( 'items' )[0];
+
+ if( firstItem ) {
+ var site = firstItem.getSite(),
+ label =
self._createItemLabel( site, '' ),
+ value =
self._createItemValue( site );
+
+ if( self._term === label ||
self._term === value ) {
+ degrade = false;
+ }
+ }
+
+ if( degrade ) {
+ self.options.menu.deactivate();
+ self.element.val( self._term );
+ self._selectedSite = null;
+ self._trigger( 'selected',
null, [null] );
+ }
}
} )
.on( 'eachchange.' + this.widgetName, function( event,
previousValue ) {
--
To view, visit https://gerrit.wikimedia.org/r/185976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73c01caaba521af8cc2a1a1c904196f676766110
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
