[MediaWiki-commits] [Gerrit] only show Blocker and Blocked labels if the task is open - change (phabricator...Sprint)

[Christopher Johnson (WMDE) (Code Review)]

Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: only show Blocker and Blocked labels if the task is open
......................................................................


only show Blocker and Blocked labels if the task is open

Bug:T87357
Change-Id: I6b354ed5cbdeacc3194bc675f7f88a3f8a078c97
---
M src/view/burndown/TasksTableView.php
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/src/view/burndown/TasksTableView.php 
b/src/view/burndown/TasksTableView.php
index 89b27c3..46f3230 100644
--- a/src/view/burndown/TasksTableView.php
+++ b/src/view/burndown/TasksTableView.php
@@ -262,20 +262,19 @@
     $date_created = phabricator_datetime($cdate, $this->viewer);
     $udate = $this->getTaskModifiedDate($task);
     $last_updated = phabricator_datetime($udate, $this->viewer);
-    $sprintpoints = id(new SprintPoints());
-    $status = $sprintpoints->getTaskStatus($task);
+    $status = $task->getStatus();
 
     $owner_link = $this->setOwnerLink($handles, $task);
     $priority = $this->getPriority($task);
     $priority_name = $this->getPriorityName($task);
 
-    if ($blocker === true) {
+    if ($blocker === true && $task->getStatus() == 'open') {
       $blockericon = $this->getIconforBlocker($ptasks);
     } else {
       $blockericon = '';
     }
 
-    if ($blocked === true) {
+    if ($blocked === true && $task->getStatus() == 'open') {
       $blockedicon = $this->getIconforBlocked();
     } else {
       $blockedicon = '';

-- 
To view, visit https://gerrit.wikimedia.org/r/186221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b354ed5cbdeacc3194bc675f7f88a3f8a078c97
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits