Dan-nl has submitted this change and it was merged.

Change subject: Do not spam gwtoolset log entries to RC
......................................................................


Do not spam gwtoolset log entries to RC

There's currently some issues with the logging of things, but
even if that wasn't there, we still don't really want these logging
notices in Special:Recentchanges or RC irc feed.

Change-Id: I6b4629aeb6916b01e73a29ef9311a3a0b42ee697
---
M includes/Utils.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Dan-nl: Verified; Looks good to me, approved



diff --git a/includes/Utils.php b/includes/Utils.php
index aa4dd1b..ad6cf42 100644
--- a/includes/Utils.php
+++ b/includes/Utils.php
@@ -412,7 +412,9 @@
                }
 
                $logid = $logEntry->insert();
-               $logEntry->publish( $logid );
+               // Do not call $logEntry->publish( $logid );
+               // as we only want this on Special:Log/gwtoolset, and not
+               // Special:Recentchanges or RC irc feed
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/186232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b4629aeb6916b01e73a29ef9311a3a0b42ee697
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Dan-nl <d_ent...@yahoo.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to