jenkins-bot has submitted this change and it was merged.
Change subject: v8 opt: enable optimisation for EventEmitter.emit
......................................................................
v8 opt: enable optimisation for EventEmitter.emit
Follows I4a0cf76f6.
Change-Id: I66501548b2ec96d050852d878e23aa47739b138f
---
M src/EventEmitter.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 12a90e8..7ab463f 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -160,12 +160,15 @@
* @return {boolean} If event was handled by at least one listener
*/
oo.EventEmitter.prototype.emit = function ( event ) {
- var i, len, binding, bindings, args, method;
+ var args = [],
+ i, len, binding, bindings, method;
if ( hasOwn.call( this.bindings, event ) ) {
// Slicing ensures that we don't get tripped up by
event handlers that add/remove bindings
bindings = this.bindings[event].slice();
- args = Array.prototype.slice.call( arguments, 1 );
+ for ( i = 1, len = arguments.length; i < len; i++ ) {
+ args.push( arguments[i] );
+ }
for ( i = 0, len = bindings.length; i < len; i++ ) {
binding = bindings[i];
if ( typeof binding.method === 'string' ) {
--
To view, visit https://gerrit.wikimedia.org/r/186379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66501548b2ec96d050852d878e23aa47739b138f
Gerrit-PatchSet: 3
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
