jenkins-bot has submitted this change and it was merged.
Change subject: Fix resizeable CSS layers
......................................................................
Fix resizeable CSS layers
Place sizeLabel above resizeHandles as resizeHandles render a 10%
black fill. Increase opacity of sizeLabel so it reads well on dark
images.
Change-Id: I29e266aa27f75a31e04f6172ce4bccc7baffb709
---
M src/ce/styles/nodes/ve.ce.ResizableNode.css
M src/ce/ve.ce.ResizableNode.js
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/styles/nodes/ve.ce.ResizableNode.css
b/src/ce/styles/nodes/ve.ce.ResizableNode.css
index 9e07165..198fc81 100644
--- a/src/ce/styles/nodes/ve.ce.ResizableNode.css
+++ b/src/ce/styles/nodes/ve.ce.ResizableNode.css
@@ -71,7 +71,7 @@
}
.ve-ce-resizableNode-sizeLabel-resizing {
- opacity: 0.75;
+ opacity: 1;
}
.ve-ce-resizableNode-sizeText {
diff --git a/src/ce/ve.ce.ResizableNode.js b/src/ce/ve.ce.ResizableNode.js
index 069da74..ba263ab 100644
--- a/src/ce/ve.ce.ResizableNode.js
+++ b/src/ce/ve.ce.ResizableNode.js
@@ -209,11 +209,10 @@
ve.ce.ResizableNode.prototype.onResizableFocus = function () {
var surface = this.getRoot().getSurface();
+ this.$resizeHandles.appendTo( surface.getSurface().$controls );
if ( this.$sizeLabel ) {
- // Attach the size label first so it doesn't mask the resize
handles
this.$sizeLabel.appendTo( surface.getSurface().$controls );
}
- this.$resizeHandles.appendTo( surface.getSurface().$controls );
// Call getScalable to pre-fetch the extended data
this.model.getScalable();
--
To view, visit https://gerrit.wikimedia.org/r/186362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29e266aa27f75a31e04f6172ce4bccc7baffb709
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
