Andrew Bogott has submitted this change and it was merged. Change subject: virt: use role, hiera ......................................................................
virt: use role, hiera See T86774 Change-Id: I5c3fd4f87183a417cc5d87d4e703302a4fe154dd Signed-off-by: Giuseppe Lavagetto <[email protected]> --- A hieradata/hosts/virt1010.yaml A hieradata/hosts/virt1011.yaml A hieradata/hosts/virt1012.yaml A hieradata/role/common/nova/compute.yaml M manifests/site.pp 5 files changed, 10 insertions(+), 20 deletions(-) Approvals: Andrew Bogott: Looks good to me, approved jenkins-bot: Verified diff --git a/hieradata/hosts/virt1010.yaml b/hieradata/hosts/virt1010.yaml new file mode 100644 index 0000000..0f97ce9 --- /dev/null +++ b/hieradata/hosts/virt1010.yaml @@ -0,0 +1 @@ +role::nova::compute::instance_dev: "/dev/sdb1" diff --git a/hieradata/hosts/virt1011.yaml b/hieradata/hosts/virt1011.yaml new file mode 100644 index 0000000..0f97ce9 --- /dev/null +++ b/hieradata/hosts/virt1011.yaml @@ -0,0 +1 @@ +role::nova::compute::instance_dev: "/dev/sdb1" diff --git a/hieradata/hosts/virt1012.yaml b/hieradata/hosts/virt1012.yaml new file mode 100644 index 0000000..d7cadae --- /dev/null +++ b/hieradata/hosts/virt1012.yaml @@ -0,0 +1,2 @@ +role::nova::compute::instance_dev: "/dev/sdb1" +cluster: virt diff --git a/hieradata/role/common/nova/compute.yaml b/hieradata/role/common/nova/compute.yaml new file mode 100644 index 0000000..4559a8a --- /dev/null +++ b/hieradata/role/common/nova/compute.yaml @@ -0,0 +1 @@ +cluster: virt diff --git a/manifests/site.pp b/manifests/site.pp index d600e3c..f88aa31 100644 --- a/manifests/site.pp +++ b/manifests/site.pp @@ -2583,26 +2583,22 @@ } node /virt100[1-9].eqiad.wmnet/ { - $cluster = 'virt' $use_neutron = false - + role nova::compute include admin include standard - include role::nova::compute if $use_neutron == true { include role::neutron::computenode } } node /virt101[0-1].eqiad.wmnet/ { - $cluster = 'virt' - openstack::nova::partition{ '/dev/sdb': } - $use_neutron = false - + openstack::nova::partition{ '/dev/sdb': } + role nova::compute include admin include standard - class { 'role::nova::compute': instance_dev => '/dev/sdb1' } + if $use_neutron == true { include role::neutron::computenode } @@ -2612,21 +2608,10 @@ # virt1012 is a nova node, similar to virt1010-1011. # Its nova-compute service is currently OFF to keep it in reserve # as a lifeboat should we need to evacuate a different virt host. - # - # To move this into active service, just remove the \# from - # the role::nova::compute line below, or consolidate in the - # /virt101[0-1].eqiad.wmnet/ section above. - $cluster = 'virt' + openstack::nova::partition{ '/dev/sdb': } - - $use_neutron = false - include admin include standard - #class { 'role::nova::compute': instance_dev => '/dev/sdb1' } - if $use_neutron == true { - include role::neutron::computenode - } } node 'iodine.wikimedia.org' { -- To view, visit https://gerrit.wikimedia.org/r/185153 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3fd4f87183a417cc5d87d4e703302a4fe154dd Gerrit-PatchSet: 4 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto <[email protected]> Gerrit-Reviewer: Andrew Bogott <[email protected]> Gerrit-Reviewer: coren <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
