jenkins-bot has submitted this change and it was merged.
Change subject: Focus the add template input in the template dialog
......................................................................
Focus the add template input in the template dialog
Focus the page in the booklet layout so the add template
input is also focused at the opening of the template dialog.
Bug: T85484
Change-Id: Id9ae4653dc2a2e1d1dc16c83c540e22e30f4ea55
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index bf77bd1..8d8e354 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -484,17 +484,16 @@
*/
ve.ui.MWTemplateDialog.prototype.initializeTemplateParameters = function () {};
-// TODO: Uncomment this when OOjs UI is updated so that .focus() on an empty
-// booklet doesn't crash.
-/*
+/**
+ * @inheritdoc
+ */
ve.ui.MWTemplateDialog.prototype.getReadyProcess = function ( data ) {
var dialog = this;
- return ve.ui.MWTemplateDialog.super.prototype.getReadyProcess.call(
this, data );
+ return ve.ui.MWTemplateDialog.super.prototype.getReadyProcess.call(
this, data )
.next( function () {
dialog.bookletLayout.focus();
} );
};
-*/
/**
* @inheritdoc
--
To view, visit https://gerrit.wikimedia.org/r/186505
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9ae4653dc2a2e1d1dc16c83c540e22e30f4ea55
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
