BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/186607

Change subject: Fix regex pattern delimiters
......................................................................

Fix regex pattern delimiters

Using `|` as the pattern delimiter breaks the use of alternation inside
the pattern:

  Warning: Unknown modifier 't':
  [|^/(?:upload|style|wiki|w|extensions)/(.*)|i] in
  /srv/mediawiki/w/404.php on line 16

Change-Id: Ide5255fb09663fcc8ad5d71710bbebab26b91ae1
---
M w/404.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/07/186607/1

diff --git a/w/404.php b/w/404.php
index b5e0e14..0c2bd5c 100644
--- a/w/404.php
+++ b/w/404.php
@@ -13,7 +13,7 @@
 header( "Cache-Control: s-maxage=2678400, max-age=2678400");
 header( "X-Wikimedia-Debug: prot=$prot serv=$serv loc=$loc");
 if( preg_match( "|(%2f)|i", $loc, $matches )
-       || preg_match( "|^/(?:upload|style|wiki|w|extensions)/(.*)|i", $loc, 
$matches )
+       || preg_match( "#^/(?:upload|style|wiki|w|extensions)/(.*)#i", $loc, 
$matches )
 ) {
        $title = htmlspecialchars( $matches[1] );
        $details = "<p style=\"font-weight: bold;\">To check for \"$title\" 
see: <a href=\"//$serv/wiki/$title\" 
title=\"$title\">$prot$serv/wiki/$title</a></p>";

-- 
To view, visit https://gerrit.wikimedia.org/r/186607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide5255fb09663fcc8ad5d71710bbebab26b91ae1
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to