XZise has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186610
Change subject: [FIX] ThreadedGenerator: Allow empty target
......................................................................
[FIX] ThreadedGenerator: Allow empty target
If the target was empty it raised a RuntimeError that the generator was
not set. It now requires to be None to raise that error.
Bug: T85667
Change-Id: I8e4a504d1673c0c9fb2e60647e432b22f7a3d48f
---
M pywikibot/tools.py
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/10/186610/1
diff --git a/pywikibot/tools.py b/pywikibot/tools.py
index 3d45090..2de47ba 100644
--- a/pywikibot/tools.py
+++ b/pywikibot/tools.py
@@ -207,12 +207,11 @@
@type qsize: int
"""
+ if target is None:
+ raise RuntimeError("No generator for ThreadedGenerator to run.")
if kwargs is None:
kwargs = {}
- if target:
- self.generator = target
- if not hasattr(self, "generator"):
- raise RuntimeError("No generator for ThreadedGenerator to run.")
+ self.generator = target
self.args, self.kwargs = args, kwargs
threading.Thread.__init__(self, group=group, name=name)
self.queue = Queue.Queue(qsize)
--
To view, visit https://gerrit.wikimedia.org/r/186610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e4a504d1673c0c9fb2e60647e432b22f7a3d48f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
