Henning Snater has uploaded a new change for review. https://gerrit.wikimedia.org/r/186765
Change subject: Removed obsolete documentation ...................................................................... Removed obsolete documentation Change-Id: Icb454b864fedf7cee163893760686d14833d3a81 --- M lib/resources/jquery.wikibase/jquery.wikibase.statementlistview.js M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js 2 files changed, 2 insertions(+), 33 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/65/186765/1 diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementlistview.js b/lib/resources/jquery.wikibase/jquery.wikibase.statementlistview.js index f8ce6c6..452b73d 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.statementlistview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementlistview.js @@ -122,8 +122,8 @@ this.element .on( afterStartEditingEvent, function( event ) { - // Forward "startediting" event for higher components (e.g. statementgrouplistview) to - // recognize that edit mode has been started. + // Forward "afterstartediting" event for higher components (e.g. statementgrouplistview) + // to recognize that edit mode has been started. self._trigger( 'afterstartediting' ); } ) .on( afterStopEditingEvent, function( event, dropValue ) { diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js index bd61655..576a827 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js @@ -58,30 +58,6 @@ * likely to be used inside the tooltip of the toolbar corresponding to the `statementview`. */ /** - * @event startediting - * Triggered when starting the view's edit mode. - * @param {jQuery.Event} event - */ -/** - * @event afterstartediting - * Triggered after having started the view's edit mode. - * @param {jQuery.Event} event - */ -/** - * @event stopediting - * Triggered when stopping the view's edit mode. - * @param {jQuery.Event} event - * @param {boolean} dropValue If true, the value from before edit mode has been started will be - * reinstated (basically, a cancel/save switch). - */ -/** - * @event afterstopediting - * Triggered after having stopped the view's edit mode. - * @param {jQuery.Event} event - * @param {boolean} dropValue If true, the value from before edit mode has been started has been - * reinstated (basically, a cancel/save switch). - */ -/** * @event afterremove * Triggered after a `referenceview` has been remove from the `statementview`'s list of * `referenceview`s. @@ -91,13 +67,6 @@ * @event change * Triggered whenever the view's content is changed. * @param {jQuery.Event} event - */ -/** - * @event toggleerror - * Triggered when an error occurred or is resolved. - * @param {jQuery.Event} event - * @param {wikibase.api.RepoApiError} [error] `wikikibase.api.RepoApiError` object if an error - * occurred, `undefined` if the current error state is resolved. */ $.widget( 'wikibase.statementview', PARENT, { /** -- To view, visit https://gerrit.wikimedia.org/r/186765 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb454b864fedf7cee163893760686d14833d3a81 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits