Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186925
Change subject: [BrowserTest] Shorten lines for clarity
......................................................................
[BrowserTest] Shorten lines for clarity
The 'I take screenshot of insert pull-down menu' step has many
similar very long lines. Shortening them makes
the code more understandable and conforming to the conventions.
Change-Id: I83b35211a6cbfdc420895469747884f3ae864479
---
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
1 file changed, 28 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/25/186925/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index 1b4ea2f..5d6b97d 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -160,22 +160,45 @@
Then(/^I take screenshot of insert pull-down menu$/) do
step 'I click on More in insert pull-down menu'
-
capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.insert_menu_element, @current_page.insert_pull_down_element])
+ capture_screenshot(
+ "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
+ [@current_page.insert_menu_element, @current_page.insert_pull_down_element]
+ )
highlight @current_page.media_insert_menu_element
-
capture_screenshot("VisualEditor_Media_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.insert_menu_element, @current_page.insert_pull_down_element],
nil, 0)
+ capture_screenshot(
+ "VisualEditor_Media_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
+ [@current_page.insert_menu_element,
@current_page.insert_pull_down_element],
+ nil,
+ 0
+ )
highlight @current_page.media_insert_menu_element, '#FFFFFF'
highlight @current_page.template_insert_menu_element
-
capture_screenshot("VisualEditor_Template_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.insert_menu_element, @current_page.insert_pull_down_element],
nil, 0)
+ capture_screenshot(
+ "VisualEditor_Template_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
+ [@current_page.insert_menu_element,
@current_page.insert_pull_down_element],
+ nil,
+ 0
+ )
highlight @current_page.template_insert_menu_element, '#FFFFFF'
highlight @current_page.ref_list_insert_menu_element
-
capture_screenshot("VisualEditor_References_List_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.insert_menu_element, @current_page.insert_pull_down_element],
nil, 0)
+ capture_screenshot(
+
"VisualEditor_References_List_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
+ [@current_page.insert_menu_element,
@current_page.insert_pull_down_element],
+ nil,
+ 0
+ )
highlight @current_page.ref_list_insert_menu_element, '#FFFFFF'
highlight @current_page.formula_insert_menu_element
-
capture_screenshot("VisualEditor_Formula_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.insert_menu_element, @current_page.insert_pull_down_element],
nil, 0)
+ capture_screenshot(
+ "VisualEditor_Formula_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
+ [@current_page.insert_menu_element,
@current_page.insert_pull_down_element],
+ nil,
+ 0
+ )
end
Then(/^I click on More in insert pull-down menu$/) do
--
To view, visit https://gerrit.wikimedia.org/r/186925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83b35211a6cbfdc420895469747884f3ae864479
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
