jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Pass correct value for isEditable in Uploads schema
......................................................................
Hygiene: Pass correct value for isEditable in Uploads schema
Use page.isEditable().
Bug: T87293
Change-Id: I9c48400cda50bfc5aae1db63a74bc44679fcab48
---
M javascripts/loggingSchemas/SchemaMobileWebUploads.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/loggingSchemas/SchemaMobileWebUploads.js
b/javascripts/loggingSchemas/SchemaMobileWebUploads.js
index a5a8916..466c342 100644
--- a/javascripts/loggingSchemas/SchemaMobileWebUploads.js
+++ b/javascripts/loggingSchemas/SchemaMobileWebUploads.js
@@ -1,6 +1,7 @@
( function ( M, $ ) {
var SchemaMobileWebUploads,
user = M.require( 'user' ),
+ page = M.getCurrentPage(),
Schema = M.require( 'Schema' );
/**
@@ -21,7 +22,7 @@
* undefined. Assigning undefined will make event logger omit
this property when sending
* the data to a server. According to the schema username is
optional.
* @cfg {Boolean} defaults.isLoggedIn Whether the user is
logged in
- * @cfg {Boolean} defaults.isEditable The value of the
wgIsPageEditable config variable
+ * @cfg {Boolean} defaults.isEditable True, if the user is able
to edit the current page, false otherwise
*/
defaults: $.extend( {}, Schema.prototype.defaults, {
pageId: mw.config.get( 'wgArticleId' ),
@@ -29,7 +30,7 @@
funnel: 'unknown',
// FIXME: Introduce a SchemaWithUser class and rethink
the data recorded that follows
username: user.getName() || undefined,
- isEditable: mw.config.get( 'wgIsPageProbablyEditable' )
+ isEditable: page.isEditable( user )
} )
} );
--
To view, visit https://gerrit.wikimedia.org/r/186740
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c48400cda50bfc5aae1db63a74bc44679fcab48
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
