Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187063
Change subject: flow: Add Page.is_flow_page() which checks contentmodel
......................................................................
flow: Add Page.is_flow_page() which checks contentmodel
Don't use flowinfo, we can get the same information by checking
the content model.
Change-Id: I8f49a609c03d30d3fd5d7ed98b353c9eaae28405
---
M pywikibot/page.py
M pywikibot/site.py
2 files changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/63/187063/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index a10291f..286e7b2 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1782,16 +1782,13 @@
u'required.' % self.title(asLink=True))
return False
+ @deprecated('Page.is_flow_page()')
def isFlowPage(self):
- """Whether the given title is a Flow page.
+ return self.isFlowPage()
- @return: bool
- """
- if not self.site.has_extension('Flow'):
- return False
- if not hasattr(self, '_flowinfo'):
- self.site.loadflowinfo(self)
- return 'enabled' in self._flowinfo
+ def is_flow_page(self):
+ """Whether a page is a Flow page."""
+ return self.content_model == 'flow-board'
# ####### DEPRECATED METHODS ########
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 3c3149c..c388187 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -2399,6 +2399,7 @@
return (pageitem['imageinfo']
if history else pageitem['imageinfo'][0])
+ @deprecated('Check the content model instead')
def loadflowinfo(self, page):
"""
Load Flow-related information about a given page.
--
To view, visit https://gerrit.wikimedia.org/r/187063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f49a609c03d30d3fd5d7ed98b353c9eaae28405
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
