Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187804
Change subject: [BrowserTest] make rubocop stop complaining
......................................................................
[BrowserTest] make rubocop stop complaining
extra lines in the language_screenshot unit test file
Change-Id: I898ad4c1ce5537c02574dd340866260c18d14cee
---
M modules/ve-mw/tests/browser/spec/rectangle_spec.rb
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/04/187804/1
diff --git a/modules/ve-mw/tests/browser/spec/rectangle_spec.rb
b/modules/ve-mw/tests/browser/spec/rectangle_spec.rb
index 30d5f2e..fe1228e 100644
--- a/modules/ve-mw/tests/browser/spec/rectangle_spec.rb
+++ b/modules/ve-mw/tests/browser/spec/rectangle_spec.rb
@@ -48,7 +48,6 @@
end
describe 'Calculate topleft co-ordinates' do
-
it 'if we provide 1 rectangle then it should return top left co-ordinates of
the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -72,11 +71,9 @@
output_coordinates = [1, 1]
expect(top_left_x_y(input_rectangles)).to eq(output_coordinates)
end
-
end
describe 'Topleft co-ordinates x' do
-
it 'if we provide 1 rectangle then it should return array of top left x
co-ordinate of the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -100,11 +97,9 @@
output_coordinates = [3, 2, 1]
expect(top_left_x_coordinates(input_rectangles)).to eq(output_coordinates)
end
-
end
describe 'Topleft co-ordinates y' do
-
it 'if we provide 1 rectangle then it should return array of top left y
co-ordinate of the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -128,11 +123,9 @@
output_coordinates = [3, 2, 1]
expect(top_left_y_coordinates(input_rectangles)).to eq(output_coordinates)
end
-
end
describe 'Calculate bottomright co-ordinates' do
-
it 'if we provide 1 rectangle then it should return bottom right
co-ordinates of the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -156,11 +149,9 @@
output_coordinates = [4, 4]
expect(bottom_right_x_y(input_rectangles)).to eq(output_coordinates)
end
-
end
describe 'Bottom right co-ordinates x' do
-
it 'if we provide 1 rectangle then it should return array of bottom right x
co-ordinate of the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -184,11 +175,9 @@
output_coordinates = [4, 3, 2]
expect(bottom_right_x_coordinates(input_rectangles)).to
eq(output_coordinates)
end
-
end
describe 'Bottom right co-ordinates y' do
-
it 'if we provide 1 rectangle then it should return array of bottom right y
co-ordinate of the input rectangle' do
input_rectangle = [2, 2, 1, 1]
input_rectangles = [input_rectangle]
@@ -212,5 +201,4 @@
output_coordinates = [4, 3, 2]
expect(bottom_right_y_coordinates(input_rectangles)).to
eq(output_coordinates)
end
-
end
--
To view, visit https://gerrit.wikimedia.org/r/187804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I898ad4c1ce5537c02574dd340866260c18d14cee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
