Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187939
Change subject: build: Fail in CI if there are resultant changes
......................................................................
build: Fail in CI if there are resultant changes
As done in VE-MW.
Change-Id: I9bd75513110a4da8c4d5cf148afe747f45c06439
---
M Gruntfile.js
1 file changed, 25 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/39/187939/1
diff --git a/Gruntfile.js b/Gruntfile.js
index 847ad7f..6814377 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -212,10 +212,34 @@
}
} );
+ grunt.registerTask( 'git-status', function () {
+ var done = this.async();
+ // Are there unstaged changes?
+ require( 'child_process' ).exec( 'git ls-files --modified',
function ( err, stdout, stderr ) {
+ var ret = err || stderr || stdout;
+ if ( ret ) {
+ grunt.log.write( ret );
+ grunt.log.error( 'Unstaged changes.' );
+ done( false );
+ } else {
+ grunt.log.ok( 'No unstaged changes.' );
+ done();
+ }
+ } );
+ } );
+
grunt.registerTask( 'build', [ 'clean', 'concat', 'cssjanus',
'cssUrlEmbed', 'copy', 'buildloader' ] );
grunt.registerTask( 'lint', [ 'jshint', 'jscs', 'csslint', 'banana' ] );
grunt.registerTask( 'unit', [ 'karma:main' ] );
- grunt.registerTask( 'test', [ 'git-build', 'build', 'lint', 'unit' ] );
+ grunt.registerTask( '_test', [ 'git-build', 'build', 'lint', 'unit' ] );
+ grunt.registerTask( 'ci', [ '_test', 'git-status' ] );
grunt.registerTask( 'watch', [ 'karma:bg:start', 'runwatch' ] );
+
+ if ( process.env.JENKINS_HOME ) {
+ grunt.registerTask( 'test', 'ci' );
+ } else {
+ grunt.registerTask( 'test', '_test' );
+ }
+
grunt.registerTask( 'default', 'test' );
};
--
To view, visit https://gerrit.wikimedia.org/r/187939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bd75513110a4da8c4d5cf148afe747f45c06439
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
