Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 33610 ......................................................................
Fixed Bug 33610 The special page code did not handle errors that can occur on property dataitem creation (e.g., if a special property ID from the database is no longer known). To fix this, it was not enough to catch this problem, because the number of results must be the same as requested (otherwise the special page will not offer navigation to the next page of results). The code was changed to return an error dataitem in this case. Several other changes were needed to appropriately process such errors in special pages using this code. Note for review: some code in the two special page files has been moved to a new function. May show as a bigger change in the diff than it actually is. Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d --- M includes/storage/SMW_Store.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M specials/QueryPages/SMW_SpecialProperties.php M specials/QueryPages/SMW_SpecialUnusedProperties.php 4 files changed, 151 insertions(+), 52 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Kghbln <mediaw...@kghoffmeyer.de> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
