Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/188338
Change subject: Drop dead code from VariantsAwareRendererTest ...................................................................... Drop dead code from VariantsAwareRendererTest Please double-check. I don't understand why the code was there in the first place. Did it had a purpose? Is there an other way to fix this, e.g. by adding a missing assertion or something? Change-Id: Ia23147defa952c3bc59f223d54b75123c21a909b --- M client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php 1 file changed, 0 insertions(+), 23 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/38/188338/1 diff --git a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php index 8697822..a7c56ba 100644 --- a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php +++ b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php @@ -2,7 +2,6 @@ namespace Wikibase\Client\Tests\DataAccess\PropertyParserFunction; -use Wikibase\Client\Usage\UsageAccumulator; use Wikibase\DataAccess\PropertyParserFunction\VariantsAwareRenderer; use Wikibase\DataModel\Entity\ItemId; @@ -17,26 +16,6 @@ * @author Katie Filbert < [email protected] > */ class VariantsAwareRendererTest extends \PHPUnit_Framework_TestCase { - - /** - * @return UsageAccumulator - */ - private function getUsageAccumulator() { - $mock = $this->getMockBuilder( 'Wikibase\Client\Usage\UsageAccumulator' ) - ->disableOriginalConstructor() - ->getMock(); - - $mock->expects( $this->any() ) - ->method( 'addLabelUsage' ); - - $mock->expects( $this->never() ) - ->method( 'addAllUsage' ); - - $mock->expects( $this->never() ) - ->method( 'addSiteLinksUsage' ); - - return $mock; - } /** * @dataProvider renderProvider @@ -57,8 +36,6 @@ $rendererFactory->expects( $this->any() ) ->method( 'getLanguageAwareRendererFromCode' ) ->will( $this->returnValue( $languageRenderer ) ); - - $usageAccumulator = $this->getUsageAccumulator(); $languageRenderers = array(); -- To view, visit https://gerrit.wikimedia.org/r/188338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia23147defa952c3bc59f223d54b75123c21a909b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
