Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188344
Change subject: Fix incomplete test in AffectedPagesFinderTest
......................................................................
Fix incomplete test in AffectedPagesFinderTest
To be honest I'm not sure what this test was supposed to do. I guess
this assertion is enough. Please tell me if you have a better idea
for an other assertion or something.
Change-Id: I14bdee9926449b6f4709c5c277726a5939c7891c
---
M client/tests/phpunit/includes/Changes/AffectedPagesFinderTest.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/44/188344/1
diff --git a/client/tests/phpunit/includes/Changes/AffectedPagesFinderTest.php
b/client/tests/phpunit/includes/Changes/AffectedPagesFinderTest.php
index 7329bad..afcaa43 100644
--- a/client/tests/phpunit/includes/Changes/AffectedPagesFinderTest.php
+++ b/client/tests/phpunit/includes/Changes/AffectedPagesFinderTest.php
@@ -13,7 +13,6 @@
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\SiteLink;
use Wikibase\ItemChange;
-use Wikibase\Lib\Store\SiteLinkLookup;
use Wikibase\Lib\Store\StorageException;
use Wikibase\Test\TestChanges;
@@ -437,6 +436,8 @@
);
$usages = $affectedPagesFinder->getAffectedUsagesByPage(
$change );
+
+ $this->assertEmpty( $usages );
}
private function getSiteLinkUsageLookup( $pageTitle ) {
--
To view, visit https://gerrit.wikimedia.org/r/188344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14bdee9926449b6f4709c5c277726a5939c7891c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
