Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/188567

Change subject: webperf: handle missing 'duration' in schema
......................................................................

webperf: handle missing 'duration' in schema

stuck in a restart loop on hafnium:

```
Traceback (most recent call last):
  File "/srv/webperf/navtiming.py", line 116, in <module>
    f(meta)
  File "/srv/webperf/navtiming.py", line 61, in handle_save_timing
    duration = event['duration']
KeyError: u'duration'
```

Bug: T85909
Change-Id: If406cc3964fd8b5178619f1b3e9d6becd3b93ece
---
M modules/webperf/files/navtiming.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/188567/1

diff --git a/modules/webperf/files/navtiming.py 
b/modules/webperf/files/navtiming.py
index 6a249a8..34e572d 100644
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -58,7 +58,7 @@
 @handles('SaveTiming')
 def handle_save_timing(meta):
     event = meta['event']
-    duration = event['duration']
+    duration = event.get('duration')
     if is_sane(duration):
         dispatch_stat('mw.performance.save', duration)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/188567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If406cc3964fd8b5178619f1b3e9d6becd3b93ece
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to