Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188699
Change subject: Turning off page-impression logging for now
......................................................................
Turning off page-impression logging for now
Not needed for any immediate tests and we can't run WikiGrok at 100%
with page-impression logging turned on. Leaving in the codebase with
instructions since we will need this for the position tests.
Change-Id: If8db28974470dd50b9adb958d6a8ae3068132f31
---
M javascripts/modules/wikigrok/WikiGrokDialog.js
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/99/188699/1
diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index 1bbb387..a608f72 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -82,11 +82,14 @@
} );
Panel.prototype.initialize.apply( this, arguments );
- // log page impression and widget impression when the
widget is shown
- this.once( 'show', function () {
- self.logPageImpression();
- self.initializeWidgetImpressionLogging();
+ // log page impression
+ // Only turn this on for bucketed tests with a
relatively small number of
+ // users, e.g. 10% of readers.
+ //self.logPageImpression();
+ // log widget impression when the widget is shown
+ this.once( 'show', function () {
+ self.initializeWidgetImpressionLogging();
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/188699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8db28974470dd50b9adb958d6a8ae3068132f31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
