Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188941
Change subject: Hygiene: Use View events in ErrorReportOverlay
......................................................................
Hygiene: Use View events in ErrorReportOverlay
Bug: T88562
Change-Id: If876eb10431be72df6ebd8bf9c53da183bb78d22
---
M javascripts/modules/errorReport/ErrorReportOverlay.js
1 file changed, 15 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/41/188941/1
diff --git a/javascripts/modules/errorReport/ErrorReportOverlay.js
b/javascripts/modules/errorReport/ErrorReportOverlay.js
index 14cb911..e9e3aae 100644
--- a/javascripts/modules/errorReport/ErrorReportOverlay.js
+++ b/javascripts/modules/errorReport/ErrorReportOverlay.js
@@ -30,10 +30,22 @@
instructions: mw.msg(
'mobile-frontend-errorreport-instructions' ),
licenseMsg: mw.msg( 'mobile-frontend-editor-licensing',
mw.config.get( 'wgMFLicenseLink' ) )
},
+ /**
+ * @inheritdoc
+ */
templatePartials: {
content: mw.template.get( 'mobile.errorReport.overlay',
'ErrorReportOverlay.hogan' )
},
+ /**
+ * @inheritdoc
+ */
className: 'error-reporting-overlay overlay',
+ /**
+ * @inheritdoc
+ */
+ events: {
+ 'click button.continue': 'onContinueClick'
+ },
/**
* Show the actual error reporting form
@@ -105,15 +117,10 @@
},
/**
- * @inheritdoc
+ * Continue button click handler
*/
- postRender: function ( options ) {
- var self = this;
-
- Overlay.prototype.postRender.apply( this, arguments );
- this.$( 'button.continue' ).on( 'click', function () {
- self._showForm( options );
- } );
+ onContinueClick: function () {
+ this._showForm( this.options );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/188941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If876eb10431be72df6ebd8bf9c53da183bb78d22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
