Umherirrender has submitted this change and it was merged.
Change subject: Remove long-deprecated ApiBase::getVersion()
......................................................................
Remove long-deprecated ApiBase::getVersion()
This method has been deprecated and uncalled since MediaWiki 1.21. Once
earlier versions of MediaWiki are no longer supported, this should be
merged to remove the method.
Bug: T35287
Change-Id: I1d5e789162d2b31d64fa52a67c1b49ddc5929da1
---
M api/ApiAddSurvey.php
M api/ApiDeleteSurvey.php
M api/ApiEditSurvey.php
M api/ApiQuerySurveyAnswers.php
M api/ApiQuerySurveySubmissions.php
M api/ApiQuerySurveys.php
M api/ApiSubmitSurvey.php
7 files changed, 4 insertions(+), 32 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
Umherirrender: Verified; Looks good to me, approved
diff --git a/api/ApiAddSurvey.php b/api/ApiAddSurvey.php
index be0b629..530f14a 100644
--- a/api/ApiAddSurvey.php
+++ b/api/ApiAddSurvey.php
@@ -111,10 +111,6 @@
return array(
'api.php?action=addsurvey&name=My awesome
survey&enabled=1&questions=',
);
- }
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
+ }
}
diff --git a/api/ApiDeleteSurvey.php b/api/ApiDeleteSurvey.php
index b407d75..3351c3d 100644
--- a/api/ApiDeleteSurvey.php
+++ b/api/ApiDeleteSurvey.php
@@ -87,10 +87,6 @@
'api.php?action=deletesurvey&ids=42',
'api.php?action=deletesurvey&ids=4|2',
);
- }
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
+ }
}
diff --git a/api/ApiEditSurvey.php b/api/ApiEditSurvey.php
index ec80db3..fb41465 100644
--- a/api/ApiEditSurvey.php
+++ b/api/ApiEditSurvey.php
@@ -101,10 +101,6 @@
return array(
'api.php?action=editsurvey&',
);
- }
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
+ }
}
diff --git a/api/ApiQuerySurveyAnswers.php b/api/ApiQuerySurveyAnswers.php
index de4af99..9f8d38e 100644
--- a/api/ApiQuerySurveyAnswers.php
+++ b/api/ApiQuerySurveyAnswers.php
@@ -132,9 +132,5 @@
'api.php?action=query&list=surveyanswers&qaquestion_id=9001&qaprops=text',
);
}
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
}
diff --git a/api/ApiQuerySurveySubmissions.php
b/api/ApiQuerySurveySubmissions.php
index 1cfc261..54ac23c 100644
--- a/api/ApiQuerySurveySubmissions.php
+++ b/api/ApiQuerySurveySubmissions.php
@@ -132,9 +132,5 @@
'api.php?action=query&list=surveysubmissions&qsuser_name=Jeroen%20De%20Dauw&qsprops=survey_id|page_id|time',
);
}
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
}
diff --git a/api/ApiQuerySurveys.php b/api/ApiQuerySurveys.php
index c48c4c8..b2912cf 100644
--- a/api/ApiQuerySurveys.php
+++ b/api/ApiQuerySurveys.php
@@ -191,8 +191,4 @@
);
}
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
-
}
diff --git a/api/ApiSubmitSurvey.php b/api/ApiSubmitSurvey.php
index 5aacf2f..603a55f 100644
--- a/api/ApiSubmitSurvey.php
+++ b/api/ApiSubmitSurvey.php
@@ -105,9 +105,5 @@
return array(
'api.php?action=submitsurvey&',
);
- }
-
- public function getVersion() {
- return __CLASS__ . ': $Id$';
- }
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/184676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5e789162d2b31d64fa52a67c1b49ddc5929da1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Survey
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
