jenkins-bot has submitted this change and it was merged.
Change subject: Make EntityAccessor::renumber private
......................................................................
Make EntityAccessor::renumber private
Change-Id: Ic97fc6adf4ca4446b265ce8b3d49575ca08143f0
---
M client/includes/scribunto/EntityAccessor.php
M client/tests/phpunit/includes/scribunto/EntityAccessorTest.php
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/scribunto/EntityAccessor.php
b/client/includes/scribunto/EntityAccessor.php
index 976c373..7c668ca 100644
--- a/client/includes/scribunto/EntityAccessor.php
+++ b/client/includes/scribunto/EntityAccessor.php
@@ -99,7 +99,7 @@
*
* @param array &$entityArr
*/
- public function renumber( array &$entityArr ) {
+ private function renumber( array &$entityArr ) {
foreach( $entityArr as &$value ) {
if ( !is_array( $value ) ) {
continue;
diff --git a/client/tests/phpunit/includes/scribunto/EntityAccessorTest.php
b/client/tests/phpunit/includes/scribunto/EntityAccessorTest.php
index f8f9e23..863a44e 100644
--- a/client/tests/phpunit/includes/scribunto/EntityAccessorTest.php
+++ b/client/tests/phpunit/includes/scribunto/EntityAccessorTest.php
@@ -3,6 +3,7 @@
namespace Wikibase\Client\Tests\Scribunto;
use Language;
+use ReflectionMethod;
use Wikibase\Client\Scribunto\EntityAccessor;
use Wikibase\Client\Usage\EntityUsage;
use Wikibase\Client\Usage\HashUsageAccumulator;
@@ -121,7 +122,9 @@
* @dataProvider provideZeroIndexedArray
*/
public function testZeroIndexArray ( array $array, array $expected ) {
- $this->getEntityAccessor()->renumber( $array );
+ $renumber = new ReflectionMethod(
'Wikibase\Client\Scribunto\EntityAccessor', 'renumber' );
+ $renumber->setAccessible( true );
+ $renumber->invokeArgs( $this->getEntityAccessor(), array(
&$array ) );
$this->assertSame( $expected, $array );
}
--
To view, visit https://gerrit.wikimedia.org/r/189029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic97fc6adf4ca4446b265ce8b3d49575ca08143f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
