jenkins-bot has submitted this change and it was merged.
Change subject: TextInputWidget: Add required attribute on the basis of
required config
......................................................................
TextInputWidget: Add required attribute on the basis of required config
Bug: T87707
Change-Id: I5a1aee6c21989e792988aa393a90df111d2b3f48
---
M demos/pages/widgets.js
M src/widgets/TextInputWidget.js
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/pages/widgets.js b/demos/pages/widgets.js
index 6637782..85e8ce7 100644
--- a/demos/pages/widgets.js
+++ b/demos/pages/widgets.js
@@ -138,7 +138,7 @@
new OO.ui.FieldLayout(
new OO.ui.IndicatorWidget( {
indicator: 'required',
- title: 'Required icon'
+ title: 'Required indicator'
} ),
{
label: 'IndicatorWidget (normal)\u200E',
@@ -148,7 +148,7 @@
new OO.ui.FieldLayout(
new OO.ui.IndicatorWidget( {
indicator: 'required',
- title: 'Required icon',
+ title: 'Required indicator',
disabled: true
} ),
{
@@ -990,9 +990,12 @@
}
),
new OO.ui.FieldLayout(
- new OO.ui.TextInputWidget( { indicator: 'required' } ),
+ new OO.ui.TextInputWidget( {
+ indicator: 'required',
+ required: true
+ } ),
{
- label: 'TextInputWidget (indicator)\u200E',
+ label: 'TextInputWidget (indicator,
required)\u200E',
align: 'top'
}
),
@@ -1047,7 +1050,7 @@
new OO.ui.FieldLayout(
new OO.ui.TextInputWidget( {
icon: 'picture',
- indicator: 'required',
+ indicator: 'alert',
value: 'Text input with label',
label: 'Inline label'
} ),
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index 39fe0d7..91572b8 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -19,6 +19,7 @@
* @cfg {boolean} [autosize=false] Automatically resize to fit content
* @cfg {boolean} [maxRows=10] Maximum number of rows to make visible when
autosizing
* @cfg {string} [labelPosition='after'] Label position, 'before' or 'after'
+ * @cfg {boolean} [required=false] Mark the field as required
* @cfg {RegExp|string} [validate] Regular expression to validate against (or
symbolic name referencing
* one, see #static-validationPatterns)
*/
@@ -81,6 +82,9 @@
if ( config.autofocus ) {
this.$input.attr( 'autofocus', 'autofocus' );
}
+ if ( config.required ) {
+ this.$input.attr( 'required', 'true' );
+ }
};
/* Setup */
--
To view, visit https://gerrit.wikimedia.org/r/187452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1aee6c21989e792988aa393a90df111d2b3f48
Gerrit-PatchSet: 7
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
