jenkins-bot has submitted this change and it was merged.
Change subject: MWCategoryItemWidget: Update CSS for OOUI changes
......................................................................
MWCategoryItemWidget: Update CSS for OOUI changes
* Add margin-right: 0 to suppress OOUI's inline spacing feature. We
can't use margin on the widgets because of how draggable works (there
may not be "gaps" between draggable elements or funny things happen).
* Set our inline spacing to 0.5em (2 × 0.25em) rather than 0.75em, to
match OOUI styles.
* Space at bottom and right rather than at top and right.
Change-Id: I90f4f47dd0c55de18e5915e610a76d0140438cc3
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryInputWidget.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryWidget.css
3 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryInputWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryInputWidget.css
index 13c7760..4de9d7d 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryInputWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryInputWidget.css
@@ -8,8 +8,7 @@
.ve-ui-mwCategoryInputWidget {
float: left;
width: 15em;
- margin-top: 0.75em;
- margin-right: -1px;
+ margin: 0 -1px 0.5em 0;
}
.ve-ui-mwCategoryInputWidget input {
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
index f9fba05..9ebaaef 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
@@ -8,10 +8,16 @@
.ve-ui-mwCategoryItemWidget {
position: relative;
float: left;
+ /* Override OOUI's inline spacing */
+ margin-right: 0;
}
.ve-ui-mwCategoryItemWidget > .oo-ui-buttonElement-button {
- margin: 0.75em 0.75em 0 0;
+ margin: 0 0.25em 0.5em 0.25em;
+}
+
+.ve-ui-mwCategoryItemWidget:last-child > .oo-ui-buttonElement-button {
+ margin-right: 0.5em;
}
.ve-ui-mwCategoryItemWidget .oo-ui-labelElement-label.new {
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryWidget.css
index 35f8192..e2ff018 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryWidget.css
@@ -6,7 +6,8 @@
*/
.ve-ui-mwCategoryWidget {
- padding: 0;
+ margin-left: -0.25em;
+ margin-right: -0.25em;
}
.ve-ui-mwCategoryWidget-items {
--
To view, visit https://gerrit.wikimedia.org/r/189117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90f4f47dd0c55de18e5915e610a76d0140438cc3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
