jenkins-bot has submitted this change and it was merged.
Change subject: PHP demo: Just echo the autoload error message, don't
trigger_error()
......................................................................
PHP demo: Just echo the autoload error message, don't trigger_error()
trigger_error() means that the error will not be displayed
under production-like PHP settings, giving just a blank page.
Change-Id: I231b5b9e181e187a9619b57aa3138c6a87f14c45
---
M demos/widgets.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/widgets.php b/demos/widgets.php
index 1e34a33..f583fec 100644
--- a/demos/widgets.php
+++ b/demos/widgets.php
@@ -1,9 +1,7 @@
<?php
$autoload = '../vendor/autoload.php';
if ( !file_exists( $autoload ) ) {
- trigger_error(
- '<h1>Did you forget to run <code>composer
install</code>?</h1>'
- );
+ echo '<h1>Did you forget to run <code>composer
install</code>?</h1>';
exit();
}
require_once $autoload;
--
To view, visit https://gerrit.wikimedia.org/r/189336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I231b5b9e181e187a9619b57aa3138c6a87f14c45
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
