Tamslo has submitted this change and it was merged.
Change subject: Some tweaks as result of the i18n review
......................................................................
Some tweaks as result of the i18n review
* No separate i18n.php file necessary. All messages belongs to json
* Add description message
* Remove from alias file German because it is identical with English
* TODO by maintainer: Please change all message prefix to
wikidataquality- instead of special-
Change-Id: Ia917347ba6ed8381402b5118342093e8711994f3
---
M WikidataQuality.alias.php
D WikidataQuality.i18n.php
M WikidataQuality.php
M i18n/en.json
M i18n/qqq.json
5 files changed, 5 insertions(+), 33 deletions(-)
Approvals:
Tamslo: Verified; Looks good to me, approved
diff --git a/WikidataQuality.alias.php b/WikidataQuality.alias.php
index 8dab198..021ef99 100644
--- a/WikidataQuality.alias.php
+++ b/WikidataQuality.alias.php
@@ -1,6 +1,6 @@
<?php
/**
- * Aliases for myextension
+ * Aliases for WikidataQuality extension
*
* @file
* @ingroup Extensions
@@ -14,10 +14,3 @@
$specialPageAliases['en'] = array(
'wikidataquality' => array( 'WikidataQuality', 'Wikidata Quality' ),
);
-
-/** Deutsch
- * @author 'BP2014N1'
- */
-$specialPageAliases['de'] = array(
- 'wikidataquality' => array( 'WikidataQuality', 'Wikidata Quality' ),
-);
\ No newline at end of file
diff --git a/WikidataQuality.i18n.php b/WikidataQuality.i18n.php
deleted file mode 100644
index 29d0e18..0000000
--- a/WikidataQuality.i18n.php
+++ /dev/null
@@ -1,23 +0,0 @@
-<?php
-/**
- * Internationalisation for WikidataQuality
- *
- * @file
- * @ingroup Extensions
- */
-$messages = array();
-
-/** English
- * @author 'BP2014N1'
- */
-$messages['en'] = array(
- "wikidataquality" => "WikidataQuality",
- "wikidataquality-desc" => "Extension's description"
-);
-
-/** Message documentation
- * @author <your username>
- */
-$messages['qqq'] = array(
- "wikidataquality-desc" => "{{desc}}",
-);
\ No newline at end of file
diff --git a/WikidataQuality.php b/WikidataQuality.php
index 4f0f41c..faf07d9 100644
--- a/WikidataQuality.php
+++ b/WikidataQuality.php
@@ -19,13 +19,12 @@
'name' => 'WikidataQuality',
'author' => 'BP2014N1',
'url' => 'https://www.mediawiki.org/wiki/Extension:WikidataQuality',
- 'descriptionmsg' => 'WikidataQuality-desc',
+ 'descriptionmsg' => 'wikidataquality-desc',
'version' => '0.0.0',
);
// Initialize localization and aliases
$wgMessagesDirs['WikidataQuality'] = __DIR__ . "/i18n";
-$wgExtensionMessagesFiles['WikidataQuality'] = __DIR__ .
"/WikidataQuality.i18n.php";
$wgExtensionMessagesFiles['WikidataQualityAlias'] = __DIR__ .
'/WikidataQuality.alias.php';
// Initalize hooks for creating database tables
diff --git a/i18n/en.json b/i18n/en.json
index d1c5dd0..2ddddec 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -2,6 +2,8 @@
"@metadata": {
"authors": "BP2014N1"
},
+ "wikidataquality-desc": "Cross check quality of Wikidata with external
databases",
+
"specialpages-group-wikidataquality": "WikidataQuality",
"special-constraintreport": "Constraint Report",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index e758651..ad76acb 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -2,6 +2,7 @@
"@metadata": {
"authors": "BP2014N1"
},
+ "wikidataquality-desc": "{{desc|name=Wikidata
Quality|url=https://www.mediawiki.org/wiki/Extension:WikidataQuality}}";,
"specialpages-group-wikidataquality": "{{doc-special-group|that=are
related to the WikidataQuality extension}}",
"special-constraintreport": "{{doc-special|ConstraintReport}}\nTitle of
the special page.",
--
To view, visit https://gerrit.wikimedia.org/r/189320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia917347ba6ed8381402b5118342093e8711994f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQuality
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Soeren.oldag <[email protected]>
Gerrit-Reviewer: Tamslo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
