jenkins-bot has submitted this change and it was merged.
Change subject: Track originalHtml in internalItems
......................................................................
Track originalHtml in internalItems
This allows us to refer back to the HTML that was used
to construct internalItems at any time.
Bug: T88650
Change-Id: Idee693b2054ceac4b6b36a715b6c22c8a88225ea
---
M src/dm/ve.dm.InternalList.js
M tests/dm/ve.dm.InternalList.test.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.InternalList.js b/src/dm/ve.dm.InternalList.js
index 206f258..4a29e34 100644
--- a/src/dm/ve.dm.InternalList.js
+++ b/src/dm/ve.dm.InternalList.js
@@ -221,7 +221,7 @@
div.innerHTML = itemHtmlQueue[i];
itemData = converter.getDataFromDomSubtree( div );
list = list.concat(
- [{ type: 'internalItem' }],
+ [{ type: 'internalItem', attributes: {
originalHtml: itemHtmlQueue[i] } }],
itemData,
[{ type: '/internalItem' }]
);
diff --git a/tests/dm/ve.dm.InternalList.test.js
b/tests/dm/ve.dm.InternalList.test.js
index 05e9cac..b46ddf8 100644
--- a/tests/dm/ve.dm.InternalList.test.js
+++ b/tests/dm/ve.dm.InternalList.test.js
@@ -50,12 +50,12 @@
internalList = doc.getInternalList(),
expectedData = [
{ type: 'internalList' },
- { type: 'internalItem' },
+ { type: 'internalItem', attributes: { originalHtml:
'Bar' } },
{ type: 'paragraph', internal: { generated: 'wrapper' }
},
'B', 'a', 'r',
{ type: '/paragraph' },
{ type: '/internalItem' },
- { type: 'internalItem' },
+ { type: 'internalItem', attributes: { originalHtml:
'Baz' } },
{ type: 'paragraph', internal: { generated: 'wrapper' }
},
'B', 'a', 'z',
{ type: '/paragraph' },
--
To view, visit https://gerrit.wikimedia.org/r/189120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee693b2054ceac4b6b36a715b6c22c8a88225ea
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
