IAlex has submitted this change and it was merged. Change subject: Simplify cached check in Special:SpecialPages ......................................................................
Simplify cached check in Special:SpecialPages There is no need to repeat the condition from QueryPage::isCached and check the misermode self. Moved the method QueryPage::isCached to SpecialPage::isCached for easy calling. Maybe in future some special pages would get cached and define its own condition for that, so making false as default. Simplify a count and add some spaces. Change-Id: I71c9991e136f9c1a6a0123ae5305b39777d9135c --- M includes/SpecialPage.php M includes/specials/SpecialSpecialpages.php 2 files changed, 21 insertions(+), 5 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29987 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c9991e136f9c1a6a0123ae5305b39777d9135c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Asher <afeld...@wikimedia.org> Gerrit-Reviewer: IAlex <ialex.w...@gmail.com> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
