Jeroen De Dauw has submitted this change and it was merged. Change subject: Store3: tablenames, usage count init, style ......................................................................
Store3: tablenames, usage count init, style This complex change prepares SQLStore3 for release. After updating, you *must* delete and recreate all Store3 tables, e.g., as follows: * first run "php SMW_refreshData.php -b SMWSQLStore3 -fp" to recreate tables and initialise property pages, * then run "php SMW_refreshData.php -b SMWSQLStore3" again to refresh all normal pages. This will not affect the functionality of Store2, if still used. The change does three things: * Change the names of the tables formerly known as smw_ids, smw_conccache, smw_stats (the first two are used by Store2 already; the last was just not very well named and easy to update with the rest); the new names are smw_object_ids, smw_concept_cache, smw_prop_stats. The rename of smw_ids is the reason why a normal setup+refresh will not do. * Update the batch computation of usage counts (in SMW_SQLStore3_SetupHandlers.php); the old computation counted only values of a property that are stored in the table that the property uses *now* to store its data, missing uses in other tables (e.g., due to new special tables being created or due to plain type changes) * The maintenance script SMW_resetStats.php is removed since its job is now done by SMW_setup.php (its old code was outdated anyway) * The broken maintenance script SMW_migration.php is disabled, printing a message on what to do instead. * Many smaller style improvements, especially in documentation. The change depends on the recent writer change, since it is not possible to separate this. Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 --- M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php M maintenance/SMW_migration.php D maintenance/SMW_resetStats.php 10 files changed, 338 insertions(+), 292 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Kghbln <mediaw...@kghoffmeyer.de> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
