Chad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189830

Change subject: Remove obvious function-level profiling
......................................................................

Remove obvious function-level profiling

Change-Id: Id8eed2304a2ad48e87cb74504d6b9bb0b50557e8
---
M ApiWikiLove.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLove 
refs/changes/30/189830/1

diff --git a/ApiWikiLove.php b/ApiWikiLove.php
index 3e95138..c501f9b 100644
--- a/ApiWikiLove.php
+++ b/ApiWikiLove.php
@@ -86,13 +86,10 @@
         * @return void
         */
        private function saveInDb( $talk, $subject, $message, $type, $email ) {
-               wfProfileIn( __METHOD__ );
-
                $dbw = wfGetDB( DB_MASTER );
                $receiver = User::newFromName( 
$talk->getSubjectPage()->getBaseText() );
                if ( $receiver === false || $receiver->isAnon() ) {
                        $this->setWarning( 'Not logging unregistered 
recipients' );
-                       wfProfileOut( __METHOD__ );
                        return;
                }
 
@@ -116,7 +113,6 @@
                } catch( DBQueryError $dbqe ) {
                        $this->setWarning( 'Action was not logged' );
                }
-               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -126,7 +122,6 @@
         * @param $token string
         */
        private function emailUser( $talk, $subject, $text, $token ) {
-               wfProfileIn( __METHOD__ );
                $api = new ApiMain( new FauxRequest(
                        array(
                                'action' => 'emailuser',
@@ -144,7 +139,6 @@
                } catch( DBQueryError $dbqe ) {
                        $this->setWarning( 'Email was not sent' );
                }
-               wfProfileOut( __METHOD__ );
        }
 
        public function getAllowedParams() {

-- 
To view, visit https://gerrit.wikimedia.org/r/189830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8eed2304a2ad48e87cb74504d6b9bb0b50557e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to