jenkins-bot has submitted this change and it was merged.

Change subject: Fix call to FormDataTransport
......................................................................


Fix call to FormDataTransport

My bad.

I removed the upload parameter to this constructor and replaced it
with a config parameter, which is great, but then I forgot to change
the call to the constructor too. So we had an upload object masquerading
as a config object, which predictably caused problems.

Bug: T89018
Change-Id: Id17ce22ebe31a2d800387a749b4105d422d3bab1
(cherry picked from commit fa553fbdd42d50e551a6347096914c9ec546413f)
---
M resources/mw.ApiUploadFormDataHandler.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mw.ApiUploadFormDataHandler.js 
b/resources/mw.ApiUploadFormDataHandler.js
index 782a551..a45fcbe 100644
--- a/resources/mw.ApiUploadFormDataHandler.js
+++ b/resources/mw.ApiUploadFormDataHandler.js
@@ -23,8 +23,7 @@
 
                this.transport = new mw.FormDataTransport(
                        this.$form[0].action,
-                       this.formData,
-                       this.upload
+                       this.formData
                ).on( 'progress', function ( evt, xhr ) {
                        var fraction;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id17ce22ebe31a2d800387a749b4105d422d3bab1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: wmf/1.25wmf16
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to