Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189912
Change subject: Don't create unnecessary engine object
......................................................................
Don't create unnecessary engine object
MetaData.__init__'s `bind` parameter can take a DB URI as well.
Change-Id: I90bd4b5a8def821ea1a0de63004841bf609ee44c
---
M server/eventlogging/handlers.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/12/189912/1
diff --git a/server/eventlogging/handlers.py b/server/eventlogging/handlers.py
index 20e964a..b08fdd0 100644
--- a/server/eventlogging/handlers.py
+++ b/server/eventlogging/handlers.py
@@ -89,8 +89,7 @@
# Don't pass 'replace' parameter to SQLAlchemy.
uri = uri_delete_query_item(uri, 'replace')
- engine = sqlalchemy.create_engine(uri)
- meta = sqlalchemy.MetaData(bind=engine)
+ meta = sqlalchemy.MetaData(bind=uri)
events = collections.deque()
worker = PeriodicThread(interval=DB_FLUSH_INTERVAL,
target=store_sql_events,
--
To view, visit https://gerrit.wikimedia.org/r/189912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90bd4b5a8def821ea1a0de63004841bf609ee44c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
