Majr has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190142
Change subject: Fix revision link in approval log
......................................................................
Fix revision link in approval log
The parameter is supposed to be "oldid". It's amazing that no one has
noticed that this link has never worked.
Change-Id: I84fedd15d96efac77a1a5518ce7473994835246f
---
M ApprovedRevs_body.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApprovedRevs
refs/changes/42/190142/1
diff --git a/ApprovedRevs_body.php b/ApprovedRevs_body.php
index 604ac23..cdd5e1e 100644
--- a/ApprovedRevs_body.php
+++ b/ApprovedRevs_body.php
@@ -114,7 +114,7 @@
if ( !$title->exists() ) {
$title->isApprovable = false;
- return $title->isApprovable;
+ return $title->isApprovable;
}
// Allow custom setting of whether the page is approvable.
@@ -243,7 +243,7 @@
}
$log = new LogPage( 'approval' );
- $rev_url = $title->getFullURL( array( 'old_id' => $rev_id ) );
+ $rev_url = $title->getFullURL( array( 'oldid' => $rev_id ) );
$rev_link = Xml::element(
'a',
array( 'href' => $rev_url ),
--
To view, visit https://gerrit.wikimedia.org/r/190142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84fedd15d96efac77a1a5518ce7473994835246f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApprovedRevs
Gerrit-Branch: master
Gerrit-Owner: Majr <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
